Skip to content

Use https proxy agent - #132

Merged
seratch merged 2 commits into
slackapi:mainfrom
EHitchcockIAG:use-https-proxy-agent
Oct 11, 2022
Merged

Use https proxy agent#132
seratch merged 2 commits into
slackapi:mainfrom
EHitchcockIAG:use-https-proxy-agent

Conversation

@EHitchcockIAG

@EHitchcockIAG EHitchcockIAG commented Sep 30, 2022 •
edited by seratch
Loading

Copy link
Copy Markdown
Contributor

Summary

Add an https-proxy-agent when HTTP proxy is used by action consumer and webhook uses HTTPS.
Issue: #131

This pull request resolves #131

Requirements (place an x in each [ ])

@seratch seratch added this to the 1.23 milestone Sep 30, 2022
@seratch seratch added the enhancement New feature or request label Sep 30, 2022
@seratch seratch self-assigned this Sep 30, 2022
seratch
seratch approved these changes Oct 3, 2022
View reviewed changes

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch
seratch requested review from filmaj and stevengill October 3, 2022 22:31
@seratch

seratch commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

@stevengill what do you think?

filmaj
filmaj approved these changes Oct 3, 2022
View reviewed changes

@filmaj filmaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this works for you @EHitchcockIAG , LGTM! Wondering how I can test this...

@seratch

seratch commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

This should be great, let me merge this PR now

@seratch
seratch merged commit acb114f into slackapi:main Oct 11, 2022
@EHitchcockIAG
EHitchcockIAG deleted the use-https-proxy-agent branch December 16, 2022 01:25
zimeg added a commit that referenced this pull request Jul 7, 2026
@zimeg Claude
docs: reference both proxy PRs in proxies() JSDoc
081de9d 
Restore the @see link to #132 alongside #205 so both PRs that shaped the
proxy behavior are documented on proxies().

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengill stevengill Awaiting requested review from stevengill
2 more reviewers
@seratch seratch seratch approved these changes
@filmaj filmaj filmaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

Axios Post Request fails behind HTTP Proxy

3 participants

@EHitchcockIAG @seratch @filmaj