Fix missing deepcopy import for event stream operations#589
Merged
Conversation
jonathan343
reviewed
Oct 27, 2025
|
|
||
| private void generateEventStreamOperation(PythonWriter writer, OperationShape operation) { | ||
| writer.pushState(new OperationSection(service, operation)); | ||
| writer.addStdlibImport("copy", "deepcopy"); |
Contributor
There was a problem hiding this comment.
Instead of adding this here, I think we should push this up to the writeSharedOperationInit method
SamRemis
added a commit
that referenced
this pull request
Nov 3, 2025
SamRemis
added a commit
to SamRemis/smithy-python
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClientGenerator was missing the deepcopy import in generateEventStreamOperation(). Services with only event stream operations fail when smithy-build runs
ruff checkon the generated code because the generated code calls deepcopy(self._config) without importing it. Non-event-stream operations already had the import.This adds the missing
writer.addStdlibImport("copy", "deepcopy")line.