Fixes multiple problems

[pftg]

• Do not require lazy loading images to be preloaded
• Fixes bug with missing wait behaviour for stable screenshoter

Summary by CodeRabbit

• New Features

  • Introduced a visibility check for images to enhance lazy-loading handling, ensuring only visible or non-lazy-loaded images are processed.

• Bug Fixes

  • Refined parameters in the screenshot capturing process to improve stability management during comparisons.
  • Enhanced robustness of the code by adding checks for the Rails module before accessing Rails.root.

[coderabbitai]

Walkthrough

The changes introduce a new function, isInViewport, which determines if an image element is visible within the browser's viewport. This function enhances the handling of lazy-loaded images by modifying the logic for returning image sources based on their visibility. Additionally, the StableScreenshoter class's initialize method has been updated to exclude the :stability_time_limit option from the capture_options hash, refining the parameters used in the screenshot capturing process. Other changes include removing unnecessary dependencies and adjusting the logic for accessing the root accessor in the Screenshot module.

Changes

Files	Change Summary
lib/capybara/screenshot/diff/browser_helpers.rb, lib/capybara/screenshot/diff/stable_screenshoter.rb	Introduced isInViewport function to check image visibility in the viewport; modified initialize method to exclude :stability_time_limit from capture_options.
lib/capybara/screenshot/diff/drivers/base_driver.rb	Removed the require "chunky_png" statement, indicating the dependency is no longer necessary.
lib/capybara/screenshot/diff/screenshoter.rb	Removed reference to Capybara.default_max_wait_time in the wait_images_loaded method.
lib/capybara_screenshot_diff.rb	Modified root accessor logic to check if the Rails module is defined before accessing Rails.root.

Poem

🐇 In the viewport bright and clear,
Lazy images, have no fear!
With a check, we’ll see the light,
Capturing moments, pure delight.
Stability’s dance, a refined tune,
Under the sun, or the silvery moon! 🌙

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef234bb and 6df60fe.

Files selected for processing (3)

• lib/capybara/screenshot/diff/drivers/base_driver.rb (0 hunks)
• lib/capybara/screenshot/diff/screenshoter.rb (0 hunks)
• lib/capybara_screenshot_diff.rb (1 hunks)

Files not reviewed due to no reviewable changes (2)

• lib/capybara/screenshot/diff/drivers/base_driver.rb
• lib/capybara/screenshot/diff/screenshoter.rb

Additional comments not posted (1)

lib/capybara_screenshot_diff.rb (1)

23-23: LGTM!

The additional check for defined?(Rails) before accessing Rails.root is a good defensive programming practice. It ensures that the root method behaves correctly in environments where Rails may not be present, preventing potential errors.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.