Conversation
darrachequesne
left a comment
darrachequesne
left a comment
Member
There was a problem hiding this comment.
Hi! Thanks for your pull request. Please find my review notes below.
| this.dispatch(args); | ||
| this.dispatch( | ||
| args, | ||
| packet.type === PacketType.BINARY_EVENT || hasBinary(args), |
Member
There was a problem hiding this comment.
Could you please explain the usage of the hasBinary() check here? Both plaintext and binary events should be complete in the ondecoded() handler, no?
|
|
||
| this.run(event, (err) => { | ||
| process.nextTick(() => { | ||
| const invoke = () => { |
Member
There was a problem hiding this comment.
Couldn't we just remove the process.nextTick() call here? Since there is already a nextTick() in the ondecoded handler.
socket.io/packages/socket.io/lib/client.ts
Lines 290 to 292 in 45873ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
When a complete non-binary event is received before disconnection,
onAny()can observe it while the named listener is skipped because dispatch is deferred until after the socket's connection state changes.New behavior
Complete non-binary events whose middleware completes synchronously are dispatched immediately while the socket is connected. Asynchronous middleware, events received after disconnection, and binary events retain their existing deferred and guarded behavior.
Other information (e.g. related issues)
Fixes #5213
The existing binary-packet regression test associated with #3095 remains unchanged and passes.