Fix 404 error#1549
Open
amirhhashemi wants to merge 1 commit into
Open
Conversation
|
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two 404 errors that happened for different reasons.
#1524: The
<ImageLinks>component was not defined properly. I think it was created during the transaction to the osmium theme. I'm not familiar with that theme and not sure if that's a bug on their side. The most reasonable fix was to move it to theosmium/src/ui/image-link.tsxfile and export it from themdx-components.tsfile.#1546 and #1472: We don't have a
warningcallout. Changed it tocaution.Closes #1546
Closes #1524
Closes #1472