Skip to content

fix: remove type-only server import remnants - #2273

Merged
birkskyum merged 2 commits into
solidjs:mainfrom
birkskyum:fix/type-only-import-dce
Jul 30, 2026
Merged

fix: remove type-only server import remnants#2273
birkskyum merged 2 commits into
solidjs:mainfrom
birkskyum:fix/type-only-import-dce

Conversation

@birkskyum

Copy link
Copy Markdown
Member

Removes type-only import remnants after unused server function imports are eliminated. Adds regression tests to ensure live value imports are preserved.

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a82b259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit a82b259
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a6b697ecad3f400082f3ff6
😎 Deploy Preview https://deploy-preview-2273--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@birkskyum
birkskyum requested a review from lxsmnsyc July 30, 2026 15:01
@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2273

commit: a82b259

Comment thread packages/start/src/directives/remove-unused-variables.ts Outdated
@birkskyum birkskyum closed this Jul 30, 2026
@birkskyum birkskyum reopened this Jul 30, 2026
@birkskyum
birkskyum requested a review from lxsmnsyc July 30, 2026 15:40
@birkskyum
birkskyum merged commit 8eef552 into solidjs:main Jul 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: removeUnusedVariables leaves type-only import specifiers alive, triggering server-only guard

2 participants