feat: implement css.filter plugin option - #2276
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8fd2c57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Contributor
Author
|
P.S. @ryansolid This also might be a great addition for the Solid v2 manifest 😅 |
birkskyum
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
+are skipped during CSS asset collection in developmentnode_modulesare always skipped in development asset collection, resulting in FOUC'sWhat is the new behavior?
+are now being processed properly in the assets manifestcss.filteroption analog toserverFunctions.filter, e.g. allowing the inclusion of certain dependenciesOther information
pnpmuses+in dependency paths. It was just easier to implement thecss.filterfeature, with the+-bug already being fixed 😅.cssfixture has a newlazy+test, making sure that regressions related to special characters will show up in the futureCSS fixture before fix
CSS fixture after fix