fix: restore the dev toolbar's optimizeDeps entries dropped in the Vite rewrite - #2282
Draft
adipascu wants to merge 1 commit into
Draft
fix: restore the dev toolbar's optimizeDeps entries dropped in the Vite rewrite#2282adipascu wants to merge 1 commit into
adipascu wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d57077a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
adipascu
force-pushed
the
fix-dev-toolbar-cjs-deps
branch
from
August 4, 2026 19:34
40e5e97 to
83eb0b4
Compare
Closed
2 tasks
adipascu
force-pushed
the
fix-dev-toolbar-cjs-deps
branch
from
August 4, 2026 23:14
83eb0b4 to
c2ed103
Compare
adipascu
changed the title
adipascu
force-pushed
the
fix-dev-toolbar-cjs-deps
branch
from
August 4, 2026 23:33
c2ed103 to
d57077a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
With the dev toolbar enabled, every dev page load throws:
source-map-jsanderror-stack-parserare CommonJS with neither anexportsnor amodulefield, so Vite serves them untransformed unless they are pre-bundled.ErrorBoundaryimportsDevToolbarstatically, so this fires on healthy pages rather than only on errors.This is a v2 regression. #1231 added both to
optimizeDepsin 2024 and every published v1 still carries it. The v2src/config/index.tsis a rewrite that never did, so every v2 release is affected,2.0.0-alpha.0through2.0.0.What is the new behavior?
Both are pre-bundled again, on the client environment, gated on
devOverlay.Other information
The
@solidjs/start >prefix is required. Both are dependencies of@solidjs/startrather than of the app, so a bare specifier does not resolve from the project root under pnpm and Vite skips the entry silently.Draft because you may prefer to drop the CommonJS dependencies from the toolbar instead.