Skip to content

Do not fail on HTTP redirects, but do not follow them either, close #22. - #23

Merged
beyang merged 2 commits into
sourcegraph:masterfrom
oree:master
Sep 6, 2016
Merged

Do not fail on HTTP redirects, but do not follow them either, close #22.#23
beyang merged 2 commits into
sourcegraph:masterfrom
oree:master

Conversation

@oree

@oree oree commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

This pull request will allow the HTTP status of redirects to be checked, without following the redirect.

This way, a redirect can be considered healthy, by configuring "up_status": 302 or "up_status": 301 in checkup.json.

For unchanged checkup.json configurations, redirects will still fail as before (as they are not HTTP status 2xx, the default expected).

@beyang
beyang merged commit 6ff4404 into sourcegraph:master Sep 6, 2016
@beyang

beyang commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants