Skip to content
This repository was archived by the owner on Mar 10, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict'

import vscode from 'vscode'

export function getSourcegraphUrl(): string {
Expand Down
2 changes: 0 additions & 2 deletions src/extension.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict'

import opn from 'opn'
import * as vscode from 'vscode'
import { getSourcegraphUrl } from './config'
Expand Down
2 changes: 0 additions & 2 deletions src/git.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict'

import execa from 'execa'
import * as path from 'path'

Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"lib": ["es6"],
"sourceMap": true,
"rootDir": "src",
"esModuleInterop": true
"esModuleInterop": true,
"strict": true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag does not mean ‘use strict’ mode. It enables strict TypeScript compile settings, which we already enable through our shared tsconfig, so this should have no effect (if it does, we should add it to the shared tsconfig instead)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you meant was alwaysStrict, but it should be added to the shared config.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict implies alwaysStrict according to this:
https://www.typescriptlang.org/docs/handbook/compiler-options.html

It was already generating js that contained 'use strict' before this, but being strict seems like a good idea anyway. I didn't remember that we had a shared config.

sourcegraph/tsconfig#2

},
"exclude": ["node_modules", ".vscode-test"]
}