Skip to content

removed mode from splitclient init#333

Merged
chillaq merged 5 commits into
FME-12858-disable-events-redisfrom
splitclient-init-rollback
Mar 5, 2026
Merged

removed mode from splitclient init#333
chillaq merged 5 commits into
FME-12858-disable-events-redisfrom
splitclient-init-rollback

Conversation

@chillaq

@chillaq chillaq commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

.NET SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@chillaq
chillaq requested a review from a team as a code owner March 3, 2026 22:10

@sanzmauro sanzmauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left minor comments, please check it before merge this PR

}

//Validate Events sent to the be.
await Task.Delay(1000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to add the delay?

@chillaq chillaq Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were failing randomly without the delay

Comment thread src/Splitio/Services/Client/Classes/SplitClient.cs Outdated
@chillaq
chillaq merged commit 4cb65d4 into FME-12858-disable-events-redis Mar 5, 2026
2 checks passed
@chillaq
chillaq deleted the splitclient-init-rollback branch March 5, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants