Skip to content

Platform interface#45

Merged
gthea merged 16 commits into
fed_baselinefrom
SDKS-6075_A
Sep 6, 2022
Merged

Platform interface#45
gthea merged 16 commits into
fed_baselinefrom
SDKS-6075_A

Conversation

@gthea

@gthea gthea commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Flutter plugin

What did you accomplish?

  • Created splitio_platform_interface package.
  • Extracted SplitioPlatform as the interface that should be implemented by platform packages.
  • Tests will be fixed once the default SplitioPlatform implementation using MethodChannel is created.

@gthea gthea self-assigned this Sep 2, 2022
@gthea
gthea requested a review from a team September 5, 2022 13:36
throw UnimplementedError();
}

Future<Map<String, dynamic>> getAllAttributes(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAllAttributes or getAttributes ?

@@ -0,0 +1,201 @@
Apache License

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I see this file, check if you need a GHA script like this one https://github.com/splitio/javascript-client/blob/development/.github/workflows/update-license-year.yml
to automatically update license files.

@gthea
gthea merged commit ec0e716 into fed_baseline Sep 6, 2022
@gthea
gthea deleted the SDKS-6075_A branch September 6, 2022 21:09
gthea added a commit that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants