Update SplitResult.toString to display null values differently#88
Merged
Conversation
When a SplitResult is converted into a string (such as when printing or running in debugger) and the config value is null, the previous implementation would display "null" as if it were a string which is confusing.
gthea
approved these changes
Nov 2, 2023
gthea
left a comment
gthea
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
SplitResultis converted into a string (such as when printing or running in debugger) and the config value isnull, the previous implementation would display"null"as if it were aStringwhich is confusing, because it isnull.Flutter plugin
What did you accomplish?
Less confusing string representation of
SplitResult.How do we test the changes introduced in this PR?
Get split results with no config, see them printed, convert them to strings in your Flutter app or view it in debugger.
Extra Notes
This would make me think that I need to handle
"null"strings instead ofnullvalues.