Skip to content

Localhost mode updates for SDK_READY_FROM_CACHE - #581

Merged
EmilianoSanchez merged 7 commits into
streaming_v2_baselinefrom
localhost_with_ready_from_cache
Sep 16, 2021
Merged

Localhost mode updates for SDK_READY_FROM_CACHE#581
EmilianoSanchez merged 7 commits into
streaming_v2_baselinefrom
localhost_with_ready_from_cache

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

JS SDK

What did you accomplish?

  • Updated localhost mode to support LocalStorage and emit SDK_READY_FROM_CACHE event.
    • As in online mode, clients emit SDK_READY_FROM_CACHE event before SDK_READY. If new clients are created after the event has been emitted, they not emit it again but can evaluate splits from cache.
    • Unlike online mode, when using LocalStorage clients always emit SDK_READY_FROM_CACHE, even the first time when there is not cached data.
  • Fixed traffic type value of mocked splits to 'localhost'.

How do we test the changes introduced in this PR?

  • Updated and added new asserts to E2E tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez changed the title Localhost mode updates for SDK_READY_FROM_CACHE [WIP] Localhost mode updates for SDK_READY_FROM_CACHE Sep 15, 2021
@EmilianoSanchez EmilianoSanchez changed the title [WIP] Localhost mode updates for SDK_READY_FROM_CACHE Localhost mode updates for SDK_READY_FROM_CACHE Sep 15, 2021
@sonarqube-pull-requests

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@EmilianoSanchez
EmilianoSanchez merged commit e8fcfaf into streaming_v2_baseline Sep 16, 2021
@EmilianoSanchez
EmilianoSanchez deleted the localhost_with_ready_from_cache branch September 16, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants