[JS migration] New source and unit test files - #628
Merged
EmilianoSanchez merged 4 commits intoFeb 3, 2022
Conversation
mmelograno
approved these changes
Feb 3, 2022
Base automatically changed from
migration_delete_source_and_utests
to
migration_baseline
February 3, 2022 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Added source files. SplitFactory function, for Node and Browser, is defined as in the new SDKs (e.g., RN, Browser) based on JS-commons:
How do we test the changes introduced in this PR?
Added new unit tests. Most validation is covered in JS-commons and by E2E tests.
Extra Notes