[JS Migration] Update EventEmitter dependency for browser - #632
Merged
EmilianoSanchez merged 4 commits intoFeb 11, 2022
Merged
Conversation
NicoZelaya
approved these changes
Feb 9, 2022
[JS Migration] Add E2E tests for streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Using an inline ES module version of EventEmitter for browser, to avoid issues with bundler tools that, by default, doesn't support CJS modules or prefer built-in modules and so it excludes the locally installed dependency in the output bundle.
How do we test the changes introduced in this PR?
Extra Notes