Skip to content

Localstorage key scoped to prefix - #643

Merged
EmilianoSanchez merged 5 commits into
developmentfrom
change/localstorageKeyChanges
Feb 25, 2022
Merged

Localstorage key scoped to prefix#643
EmilianoSanchez merged 5 commits into
developmentfrom
change/localstorageKeyChanges

Conversation

@NicoZelaya

Copy link
Copy Markdown
Contributor

JS SDK

What did you accomplish?

  • Scoped my segments data in localstorage inside the same prefix than the other keys.

How do we test the changes introduced in this PR?

  • Run the unit tests
  • Validate running on a web, you can introduce a few old keys from the console. Reach out to me if you want some example sentences.

Extra Notes

  • The goal is to make the change without leaving old cache keys behind.

@EmilianoSanchez EmilianoSanchez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilianoSanchez
EmilianoSanchez merged commit 677a7f0 into development Feb 25, 2022
@EmilianoSanchez
EmilianoSanchez deleted the change/localstorageKeyChanges branch February 25, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants