Add bloom filter - #692
Merged
Merged
Conversation
| @@ -0,0 +1,22 @@ | |||
| import tape from 'tape-catch'; | |||
Contributor
There was a problem hiding this comment.
Rename the file to bloomFilter.spec.js, to indicate that this is the unit test for bloomFilter.js
| @@ -0,0 +1,32 @@ | |||
| import { BloomFilter } from '@ably/bloomit'; | |||
|
|
|||
| export function getBloomFilter(spectedInsertions, errorRate) { | |||
Contributor
There was a problem hiding this comment.
expectedInsertions ? fix typo in all occurrences
|
|
||
| if (spectedInsertions) __spectedInsertions = spectedInsertions; | ||
| if (errorRate) __errorRate = errorRate; | ||
| __filter = BloomFilter.create(__spectedInsertions, __errorRate); |
Contributor
There was a problem hiding this comment.
You can simplify lines 3 to 10 by using default parameters:
export function getBloomFilter(spectedInsertions = 10000000, errorRate = 0.01) {
const __filter = BloomFilter.create(spectedInsertions, errorRate);
EmilianoSanchez
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Created Bloom filter
How do we test the changes introduced in this PR?
Unit tests included
Extra Notes