Skip to content

Update js-yaml dependency - #695

Merged
EmilianoSanchez merged 2 commits into
developmentfrom
refactor_localhostfromfile
Jul 21, 2022
Merged

Update js-yaml dependency#695
EmilianoSanchez merged 2 commits into
developmentfrom
refactor_localhostfromfile

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Jul 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

JS SDK

What did you accomplish?

Move js-yaml dependency from @splitsoftware/splitio-commons to @splitsoftware/splitio, to avoid issues in Node v14 when installing third-party dependencies that also uses js-yaml as a transitive dependency (Related to #662 )

How do we test the changes introduced in this PR?

Covered by E2E tests already.

Reproduction steps:

nvm use 14
npm install @splitsoftware/splitio@10.20.1-rc.1 js-yaml@4.0.0
npm uninstall js-yaml

Extra Notes

@EmilianoSanchez
EmilianoSanchez merged commit 7c60f5e into development Jul 21, 2022
@EmilianoSanchez
EmilianoSanchez deleted the refactor_localhostfromfile branch July 21, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gthea gthea gthea approved these changes
+1 more reviewer
@emmaz90 emmaz90 emmaz90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmilianoSanchez @gthea @emmaz90