[SDKS-5960] Send bloom filter to unique keys tracker - #702
Merged
Conversation
…ty and factory name
EmilianoSanchez
approved these changes
Jul 27, 2022
| return true; | ||
| }, | ||
|
|
||
| contains(data) { |
Contributor
There was a problem hiding this comment.
Add to checklist for future polishing: if the contains method is not used anywhere, remove it here and from IFilterAdapter interface
Contributor
Author
There was a problem hiding this comment.
Added to the polishing list 📝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Send bloom filter to unique keys tracker
Fix bloom filter functionality and factory name
How do we test the changes introduced in this PR?
Extra Notes