[SDKS-5964, SDKS-5965] Add E2E tests. fix bloom filter behaviour - #707
Merged
Conversation
gthea
approved these changes
Aug 9, 2022
gthea
reviewed
Aug 9, 2022
| segmentsRefreshRate: 1, | ||
| impressionsRefreshRate: 3000, | ||
| impressionsQueueSize: 3, // flush impressions when 3 are queued | ||
| uniqueKeysCacheSize: 7 // flush impressions when 3 are queued |
There was a problem hiding this comment.
Suggested change
| uniqueKeysCacheSize: 7 // flush impressions when 3 are queued | |
| uniqueKeysCacheSize: 7 // flush impressions when 7 are queued |
EmilianoSanchez
approved these changes
Aug 9, 2022
| // Mocking this specific route to make sure we only get the items we want to test from the handlers. | ||
| fetchMock.getOnce(url(settings, '/splitChanges?since=-1'), { status: 200, body: splitChangesMock1 }); | ||
| fetchMock.get(url(settings, '/splitChanges?since=1457552620999'), { status: 200, body: splitChangesMock2 }); | ||
| fetchMock.get(url(settings, '/splitChanges?since=1457552620999'), { status: 200, body: splitChangesMock2 }); |
Contributor
There was a problem hiding this comment.
Delete this line if possible. I think it is duplicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Added uniqueKeysTracker E2E tests for Node and Browser
How do we test the changes introduced in this PR?
Extra Notes