Skip to content

Update defaults and min value of impressionsRefreshRate config param - #114

Merged
EmilianoSanchez merged 1 commit into
telemetry_baselinefrom
impressions_refresh_rate_defaults_and_mins
May 5, 2022
Merged

Update defaults and min value of impressionsRefreshRate config param#114
EmilianoSanchez merged 1 commit into
telemetry_baselinefrom
impressions_refresh_rate_defaults_and_mins

Conversation

@EmilianoSanchez

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • When impressionsMode == DEBUG: Min: 1 sec, Default: 60 sec
  • When impressionsMode == OPTIMIZED: Min: 60 sec, Default : 5 min

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

Base automatically changed from telemetry_config_param to telemetry_baseline May 2, 2022 17:50
@EmilianoSanchez
EmilianoSanchez merged commit 7d210c9 into telemetry_baseline May 5, 2022
@EmilianoSanchez
EmilianoSanchez deleted the impressions_refresh_rate_defaults_and_mins branch May 5, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants