Skip to content

SDKS-5789. Add singleSync config parameter - #126

Merged
emmaz90 merged 3 commits into
single-syncfrom
add-config
Jun 6, 2022
Merged

SDKS-5789. Add singleSync config parameter#126
emmaz90 merged 3 commits into
single-syncfrom
add-config

Conversation

@emmaz90

@emmaz90 emmaz90 commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

Added config param for single sync

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

impressionsMode: OPTIMIZED,
localhostMode: undefined
localhostMode: undefined,
singleSync: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add validation, similar to streamingEnabled

@emmaz90
emmaz90 merged commit 40f097b into single-sync Jun 6, 2022
@emmaz90
emmaz90 deleted the add-config branch June 6, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants