Add single sync functionality for main client - #133
Merged
Conversation
NicoZelaya
approved these changes
Jun 14, 2022
|
|
||
| syncManager.start(); | ||
|
|
||
| expect(pollingManager.start).not.toBeCalled(); |
Contributor
There was a problem hiding this comment.
Can we pass to syncManagerOnlineFactory, a push manager and validate that the streaming flow hasn't been called either?
Contributor
Author
There was a problem hiding this comment.
sure, I get to work on it
Contributor
There was a problem hiding this comment.
I was late reviewing this PR, but other option is to not instantiate the pushManager if singleSync is true.
const pushManager = !singleSync && streamingEnabled && pollingManager && pushManagerFactory ?
pushManagerFactory(params, pollingManager) :
undefined;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javascript commons library
What did you accomplish?
Added single sync functionality for main client
How do we test the changes introduced in this PR?
tests included
Extra Notes