Skip to content

Update config name from sync.singleSync to sync.enabled - #135

Merged
emmaz90 merged 2 commits into
single-syncfrom
sync-enabled-config
Jun 22, 2022
Merged

Update config name from sync.singleSync to sync.enabled#135
emmaz90 merged 2 commits into
single-syncfrom
sync-enabled-config

Conversation

@emmaz90

@emmaz90 emmaz90 commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

Update config name from sync.singleSync to sync.enabled

How do we test the changes introduced in this PR?

Tests included

Extra Notes

@EmilianoSanchez EmilianoSanchez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to check before merging

Comment thread CHANGES.txt Outdated
Comment thread src/sync/syncManagerOnline.ts Outdated
Comment thread src/sync/syncManagerOnline.ts Outdated
@emmaz90
emmaz90 merged commit 4efa8b0 into single-sync Jun 22, 2022
@emmaz90
emmaz90 deleted the sync-enabled-config branch June 22, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants