Skip to content

Browser listener updates - #137

Merged
EmilianoSanchez merged 7 commits into
developmentfrom
browser_listener_update
Jul 5, 2022
Merged

Browser listener updates#137
EmilianoSanchez merged 7 commits into
developmentfrom
browser_listener_update

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

Decouple data flush from streaming close, to handle on different browser events:

  • streaming close with unload
  • data flush with pagehide and visibilitychange

How do we test the changes introduced in this PR?

  • Unit tests
  • Manual validation in mobile and Web browsers

Extra Notes

@EmilianoSanchez
EmilianoSanchez changed the base branch from development to single-sync June 27, 2022 14:32
@EmilianoSanchez EmilianoSanchez changed the title Browser listener updates [WIP] Browser listener updates Jun 27, 2022
Base automatically changed from single-sync to development June 29, 2022 15:26
@EmilianoSanchez
EmilianoSanchez merged commit c44ac58 into development Jul 5, 2022
@EmilianoSanchez
EmilianoSanchez deleted the browser_listener_update branch July 5, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants