Skip to content

Streaming updates: refactor settings validation and polishing - #3

Merged
EmilianoSanchez merged 3 commits into
streaming_updates_baselinefrom
streaming_updates_multiple_refactors
Mar 9, 2021
Merged

Streaming updates: refactor settings validation and polishing#3
EmilianoSanchez merged 3 commits into
streaming_updates_baselinefrom
streaming_updates_multiple_refactors

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • Updated settings validation: added pushRetryBackoffBase param and removed the deprecated ones.
  • Polishing: moved readiness-related constants into a separate file.
  • added info log for SDK_READY event.
  • removed ready function deprecation comment.

How do we test the changes introduced in this PR?

  • Updated some tests

Extra Notes

@NicoZelaya NicoZelaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilianoSanchez
EmilianoSanchez changed the base branch from streaming_updates_services to streaming_updates_baseline March 9, 2021 15:37
@EmilianoSanchez
EmilianoSanchez merged commit 79938d2 into streaming_updates_baseline Mar 9, 2021
@EmilianoSanchez
EmilianoSanchez deleted the streaming_updates_multiple_refactors branch September 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants