Skip to content

Update localhost mode to not use LocalStorage directly - #54

Merged
EmilianoSanchez merged 4 commits into
pluggable_storage_baselinefrom
localhost_with_ready_from_cache
Oct 14, 2021
Merged

Update localhost mode to not use LocalStorage directly#54
EmilianoSanchez merged 4 commits into
pluggable_storage_baselinefrom
localhost_with_ready_from_cache

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • Added type property to storage factory modules, which is used for:
    • validating the user storage config param
    • distinguish the InLocalStorage module to fallback into memory in localhost mode
  • Updated storage validator for browser

How do we test the changes introduced in this PR?

  • Updated tests for storage validator for browser.

Extra Notes

@EmilianoSanchez EmilianoSanchez changed the title [WIP] Update localhost mode to not use LocalStorage directly Update localhost mode to not use LocalStorage directly Oct 7, 2021
@EmilianoSanchez
EmilianoSanchez merged commit 34a15f4 into pluggable_storage_baseline Oct 14, 2021
@EmilianoSanchez
EmilianoSanchez deleted the localhost_with_ready_from_cache branch October 14, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants