Refactor to avoid interoperability issues with ESM and CJS builds - #65
Merged
Conversation
…gn dependency with inline ES module
EmilianoSanchez
changed the title
mmelograno
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javascript commons library
What did you accomplish?
Replaced default exports with named exports, to avoid issues with some particular Webpack configs that doesn't work fine with CommonJS modules transpiled by TSC.
Replaced object-assign dependency with an inline ES module version of it, to avoid extra configuration steps to handle CommonJS modules with bundlers that uses ESM by default (E.g.: no need to set CommonJS plugin in Rollup).
Added linter rule to avoid default exports.
How do we test the changes introduced in this PR?
Manually tested in rollup and webpack projects.
Extra Notes