Skip to content

Add impressions queue size limit functionality - #79

Merged
EmilianoSanchez merged 2 commits into
developmentfrom
impressions_queue_size_limit
Feb 22, 2022
Merged

Add impressions queue size limit functionality#79
EmilianoSanchez merged 2 commits into
developmentfrom
impressions_queue_size_limit

Conversation

@EmilianoSanchez

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • Update impressions cache to call a listener when queue is full.
  • Integrate the impressions full queue listener with the impression submitter to flush impressions.
  • Add impressionsQueueSize config param with 30000 as default value.

How do we test the changes introduced in this PR?

  • Add unit tests for impressions cache.

Extra Notes

@EmilianoSanchez
EmilianoSanchez force-pushed the impressions_queue_size_limit branch from 4d27390 to b6fe47d Compare February 17, 2022 15:59
@EmilianoSanchez
EmilianoSanchez merged commit c0a1b69 into development Feb 22, 2022
@EmilianoSanchez
EmilianoSanchez deleted the impressions_queue_size_limit branch February 22, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants