Skip to content

User consent refactors and fixes - #88

Merged
EmilianoSanchez merged 4 commits into
user_consent_baselinefrom
user_consent_trackers_refactor
Mar 15, 2022
Merged

User consent refactors and fixes#88
EmilianoSanchez merged 4 commits into
user_consent_baselinefrom
user_consent_trackers_refactor

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Mar 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • Logic to bypass tracking events and impressions depending on consent is done in trackers, instead of the client track and getTreatment* methods.
  • Fixed Map ponyfill, to work on browsers with partial support of the Map built-in (like IE11)
  • Updated client.isBrowserClient flag to client.isClientSide

How do we test the changes introduced in this PR?

  • Unit tests were moved to trackers.

Extra Notes

Base automatically changed from user_consent_polishing to user_consent_baseline March 8, 2022 21:15
@EmilianoSanchez EmilianoSanchez changed the title User consent refactor User consent refactors and fixes Mar 9, 2022
@EmilianoSanchez
EmilianoSanchez merged commit 20cb703 into user_consent_baseline Mar 15, 2022
@EmilianoSanchez
EmilianoSanchez deleted the user_consent_trackers_refactor branch March 15, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@emmaz90 emmaz90 emmaz90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez @emmaz90