Skip to content

Validate and sanitize key and trafficType in settings - #90

Merged
EmilianoSanchez merged 6 commits into
user_consent_baselinefrom
settings_key_and_tt_validation
Mar 31, 2022
Merged

Validate and sanitize key and trafficType in settings#90
EmilianoSanchez merged 6 commits into
user_consent_baselinefrom
settings_key_and_tt_validation

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

Javascript commons library

What did you accomplish?

  • Validate and sanitize config key and TT during settings validation, instead of inside the SDK client method, to avoid issues with other internal modules that read the key/TT value from settings, like the SyncManager.
  • Fixed a dependency vulnerability

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez changed the title Validate and sanitize key and trafficType in settings [WIP] Validate and sanitize key and trafficType in settings Mar 29, 2022
@EmilianoSanchez
EmilianoSanchez force-pushed the settings_key_and_tt_validation branch from 448b47b to f053eaf Compare March 31, 2022 16:41
@EmilianoSanchez
EmilianoSanchez merged commit dd08b91 into user_consent_baseline Mar 31, 2022
@EmilianoSanchez
EmilianoSanchez deleted the settings_key_and_tt_validation branch March 31, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants