Skip to content

fixed exception when new flagset detected #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillaq merged 2 commits into from
Oct 17, 2023
Merged

fixed exception when new flagset detected #473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1add907
fixed exception when new flagset detected
chillaq Oct 12, 2023
576a0f4
cleanup
chillaq Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion splitio/storage/inmemmory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def _remove_from_flag_sets(self, feature_flag):
if feature_flag.sets is not None:
for flag_set in feature_flag.sets:
self.flag_set.remove_feature_flag_to_flag_set(flag_set, feature_flag.name)
if len(self.flag_set.get_flag_set(flag_set)) == 0 and not self.flag_set_filter.should_filter:
if self.is_flag_set_exist(flag_set) and len(self.flag_set.get_flag_set(flag_set)) == 0 and not self.flag_set_filter.should_filter:
self.flag_set.remove_flag_set(flag_set)

def get_feature_flags_by_sets(self, sets):
Expand Down