Skip to content

Add flagSets prop to SplitTreatments component and useSplitTreatments hook#168

Merged
EmilianoSanchez merged 18 commits into
hooks_baselinefrom
flagSets
Nov 15, 2023
Merged

Add flagSets prop to SplitTreatments component and useSplitTreatments hook#168
EmilianoSanchez merged 18 commits into
hooks_baselinefrom
flagSets

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

React SDK

What did you accomplish?

  • Add optional flagSets prop to SplitTreatments component.
  • Add optional flagSets option to useSplitTreatments hook.
  • Add warning log if both names and flagSets params are provided.

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez
EmilianoSanchez changed the base branch from hooks_export to hooks_baseline November 13, 2023 19:37
@EmilianoSanchez
EmilianoSanchez changed the base branch from hooks_baseline to hooks_export November 14, 2023 14:14
Base automatically changed from hooks_export to hooks_baseline November 14, 2023 14:24
@EmilianoSanchez EmilianoSanchez changed the title [WIP] Add flagSet prop to SplitTreatments component and useSplitTreatments hook Add flagSet prop to SplitTreatments component and useSplitTreatments hook Nov 14, 2023
@EmilianoSanchez EmilianoSanchez changed the title Add flagSet prop to SplitTreatments component and useSplitTreatments hook Add flagSets prop to SplitTreatments component and useSplitTreatments hook Nov 14, 2023
@EmilianoSanchez
EmilianoSanchez marked this pull request as ready for review November 14, 2023 16:50
@EmilianoSanchez
EmilianoSanchez requested a review from a team as a code owner November 14, 2023 16:50
Comment thread src/constants.ts
@EmilianoSanchez
EmilianoSanchez merged commit 45c9b7e into hooks_baseline Nov 15, 2023
@EmilianoSanchez
EmilianoSanchez deleted the flagSets branch November 15, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants