Add SplitFactoryProvider component and deprecate SplitFactory component and withSplitFactory HOC#182
Merged
EmilianoSanchez merged 21 commits intoJan 16, 2024
Conversation
…ponent and withSplitFactory HOC
EmilianoSanchez
force-pushed
the
new_SplitFactoryProvider_component
branch
from
January 11, 2024 18:23
e896839 to
dc6cdf7
Compare
EmilianoSanchez
force-pushed
the
new_SplitFactoryProvider_component
branch
from
January 11, 2024 20:43
dc6cdf7 to
0b869f9
Compare
emmaz90
approved these changes
Jan 15, 2024
Polishing: replace `SplitFactory` for `SplitFactoryProvider` in comments and tests
Update logs for `SplitFactoryProvider` component
|
SonarQube Quality Gate
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React SDK
What did you accomplish?
SplitFactoryProvideras a drop-in replacement forSplitFactory. SplitFactoryComponent is a fixed version of SplitFactory, where side effects are moved to the commit-phase. This fixes issues related to factory reinitialization in development mode and allows the use of the library on server side.How do we test the changes introduced in this PR?
Extra Notes