Skip to content

Add MIGRATION-GUIDE.md file#188

Merged
EmilianoSanchez merged 19 commits into
developmentfrom
migration-guide
Feb 2, 2024
Merged

Add MIGRATION-GUIDE.md file#188
EmilianoSanchez merged 19 commits into
developmentfrom
migration-guide

Conversation

@EmilianoSanchez

Copy link
Copy Markdown
Contributor

React SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez
EmilianoSanchez requested a review from a team as a code owner January 31, 2024 14:52

@lenasano lenasano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide already looks great! My suggestions cover the following goals:

  • rewrite some text (i.e. of my originality) to reassure the reader (informing, but not alarming), as per some excellent feedback from Nico
  • some changes for clarity
  • add one additional piece of information that I think covers a 'gotcha' recently encountered, but Emi can confirm

Happy to iterate and get this great guide out!

Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md Outdated
Comment thread MIGRATION-GUIDE.md
Comment thread MIGRATION-GUIDE.md Outdated

@lenasano lenasano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In good shape, so approving this guide for publishing. The few comments left, you can resolve at your discretion, Emi.
(Just make sure you click the "3 hidden conversations... Load more" link above.) 💪

Comment thread MIGRATION-GUIDE.md Outdated
EmilianoSanchez and others added 2 commits February 2, 2024 17:17
Co-authored-by: lenasano <114319916+lenasano@users.noreply.github.com>
@sonarqube-pull-requests

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@EmilianoSanchez
EmilianoSanchez merged commit 03c7bc9 into development Feb 2, 2024
@EmilianoSanchez
EmilianoSanchez deleted the migration-guide branch February 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants