Skip to content

Handle defaults of updateOnSdk props, when non boolean values are provided#219

Merged
EmilianoSanchez merged 15 commits into
developmentfrom
fix_on_update_props
Dec 4, 2024
Merged

Handle defaults of updateOnSdk props, when non boolean values are provided#219
EmilianoSanchez merged 15 commits into
developmentfrom
fix_on_update_props

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

React SDK

What did you accomplish?

  • Fixed an issue with the updateOn*** object parameters of the useSplitClient and useSplitTreatments hooks, and their components and HOCs alternatives, which were not defaulting to true when a non-boolean value was provided.

How do we test the changes introduced in this PR?

  • Updated unit tests.

Extra Notes

@EmilianoSanchez
EmilianoSanchez requested a review from a team as a code owner November 5, 2024 17:05
@sonarqube-pull-requests

Copy link
Copy Markdown

@EmilianoSanchez
EmilianoSanchez merged commit 14e5e58 into development Dec 4, 2024
@EmilianoSanchez
EmilianoSanchez deleted the fix_on_update_props branch December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants