Fix useSplitClient hook to properly respect updateOn<Event> options when the function is re-called#232
Merged
Merged
Conversation
NicoZelaya
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React SDK
What did you accomplish?
Fix a wrong behaviour with
useSplitClienthook, that was not properly memoizing the internal client status according to the providedupdateOn<Event>options, resulting in unexpected re-evaluations when the SDK was updated and the hook function re-called due to a re-render in the component.How do we test the changes introduced in this PR?
Added tests to avoid regressions.
Extra Notes