Skip to content

React Native SignalListener implementation - #4

Merged
EmilianoSanchez merged 6 commits into
developmentfrom
rn_signal_listener
Jul 20, 2021
Merged

React Native SignalListener implementation#4
EmilianoSanchez merged 6 commits into
developmentfrom
rn_signal_listener

Conversation

@EmilianoSanchez

@EmilianoSanchez EmilianoSanchez commented Jul 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

React Native SDK

What did you accomplish?

  • Added React Native SignalListener implementation, to monitor basic app state (foreground/background) in order to pause/resume streaming and flush data.

How do we test the changes introduced in this PR?

  • Added RNSignalListener unit tests.
  • Tested manually in example app, that will be submitted in a coming PR.

Extra Notes

@EmilianoSanchez
EmilianoSanchez changed the base branch from travis_config to development July 15, 2021 18:32
@EmilianoSanchez EmilianoSanchez changed the title React Native SignalListener implementation [WIP] React Native SignalListener implementation Jul 19, 2021
emilianofant-split
emilianofant-split approved these changes Jul 20, 2021
View reviewed changes

@emilianofant-split emilianofant-split left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM!

@EmilianoSanchez
EmilianoSanchez merged commit 76900cf into development Jul 20, 2021
@EmilianoSanchez
EmilianoSanchez deleted the rn_signal_listener branch July 20, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@emilianofant-split emilianofant-split emilianofant-split approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez @emilianofant-split