Skip to content

AUT-1705: Add Sonar to SDK react-native-client.#41

Merged
gpochettino merged 2 commits into
mainfrom
enhancement/AUT-1705
Dec 19, 2022
Merged

AUT-1705: Add Sonar to SDK react-native-client.#41
gpochettino merged 2 commits into
mainfrom
enhancement/AUT-1705

Conversation

@gpochettino

@gpochettino gpochettino commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

React Native SDK

What did you accomplish?

Adding SonarQube step to CI in order have a check for code quality

Since main and development are two permanent branches, we are having two executions in order to make sonar to know about the parent branch.

How do we test the changes introduced in this PR?

Testing from this PR if the step is being executed and giving the right output.

From SonarQube site this PR is being analyzed and showing code coverage.
https://sonarqube.split-internal.com/dashboard?id=react-native-client&pullRequest=41

Screen Shot 2022-12-14 at 13 43 15

Enabled decoration for PR:
Screen Shot 2022-12-14 at 13 56 28

Extra Notes

Java & iOS files were excluded from the analysis.

In order to get the blame information to SonarQube, we told GitHubActions to clone the entire history. This was done on this section:

      - name: Checkout code
        uses: actions/checkout@v3
        with:
          fetch-depth: 0

From SonarQube site Cristian applied the following changes:

  • Renamed main branch to main since by default SonarQube uses master as main branch.
  • Enabled PullRequest decoration

@gpochettino
gpochettino force-pushed the enhancement/AUT-1705 branch 2 times, most recently from bf8b30f to 9a85d41 Compare December 14, 2022 16:39
@gpochettino
gpochettino marked this pull request as ready for review December 14, 2022 17:03
@sonarqube-pull-requests

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gpochettino
gpochettino requested a review from a team December 15, 2022 13:00
@gpochettino
gpochettino merged commit bd17dcc into main Dec 19, 2022
@gpochettino
gpochettino deleted the enhancement/AUT-1705 branch December 19, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants