AUT-1705: Add Sonar to SDK react-native-client.#41
Merged
Conversation
gpochettino
force-pushed
the
enhancement/AUT-1705
branch
2 times, most recently
from
December 14, 2022 16:39
bf8b30f to
9a85d41
Compare
gpochettino
force-pushed
the
enhancement/AUT-1705
branch
from
December 14, 2022 16:54
9a85d41 to
038f796
Compare
Israphel
approved these changes
Dec 14, 2022
gpochettino
marked this pull request as ready for review
December 14, 2022 17:03
|
SonarQube Quality Gate |
melinaurruchua
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








React Native SDK
What did you accomplish?
Adding SonarQube step to CI in order have a check for code quality
Since main and development are two permanent branches, we are having two executions in order to make sonar to know about the parent branch.
How do we test the changes introduced in this PR?
Testing from this PR if the step is being executed and giving the right output.
From SonarQube site this PR is being analyzed and showing code coverage.
https://sonarqube.split-internal.com/dashboard?id=react-native-client&pullRequest=41
Enabled decoration for PR:

Extra Notes
Java & iOS files were excluded from the analysis.
In order to get the blame information to SonarQube, we told GitHubActions to clone the entire history. This was done on this section:
From SonarQube site Cristian applied the following changes: