Skip to content

Update CI/CD configuration, README and type definition comments #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilianoSanchez merged 1 commit into from
Jul 5, 2023
Merged

Update CI/CD configuration, README and type definition comments #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ on:
pull_request:
branches:
- main
pull_request_target:
branches:
- development
push:
branches:
Expand Down Expand Up @@ -56,7 +58,7 @@ jobs:
-Dsonar.links.scm="https://github.com/splitio/${{ github.event.repository.name }}"

- name: SonarQube Scan (Pull Request)
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
uses: SonarSource/sonarcloud-github-action@v1.8
env:
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-license-year.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Split has built and maintains SDKs for:

* .NET [Github](https://github.com/splitio/dotnet-client) [Docs](https://help.split.io/hc/en-us/articles/360020240172--NET-SDK)
* Android [Github](https://github.com/splitio/android-client) [Docs](https://help.split.io/hc/en-us/articles/360020343291-Android-SDK)
* Angular [Github](https://github.com/splitio/angular-sdk-plugin) [Docs](https://help.split.io/hc/en-us/articles/6495326064397-Angular-utilities)
* GO [Github](https://github.com/splitio/go-client) [Docs](https://help.split.io/hc/en-us/articles/360020093652-Go-SDK)
* iOS [Github](https://github.com/splitio/ios-client) [Docs](https://help.split.io/hc/en-us/articles/360020401491-iOS-SDK)
* Java [Github](https://github.com/splitio/java-client) [Docs](https://help.split.io/hc/en-us/articles/360020405151-Java-SDK)
Expand Down
6 changes: 3 additions & 3 deletions types/splitio.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,14 +1023,14 @@ declare namespace SplitIO {
*/
setAttribute(attributeName: string, attributeValue: AttributeType): boolean,
/**
* Returns the attribute with the given key.
* Returns the attribute with the given name.
*
* @param {string} attributeName Attribute name
* @returns {AttributeType} Attribute with the given key
* @returns {AttributeType} Attribute with the given name
*/
getAttribute(attributeName: string): AttributeType,
/**
* Removes from client's in memory attributes storage the attribute with the given key.
* Removes from client's in memory attributes storage the attribute with the given name.
*
* @param {string} attributeName
* @returns {boolean} true if attribute was removed and false otherwise
Expand Down