Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/splitclient-rb/engine/api/splits.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ def since(since, fetch_options = { cache_control_headers: false, till: nil })
result = splits_with_segment_names(response.body)

unless result[:splits].empty?
@config.split_logger.log_if_debug("#{result[:splits].length} splits retrieved. since=#{since}")
@config.split_logger.log_if_debug("#{result[:splits].length} feature flags retrieved. since=#{since}")
end
@config.split_logger.log_if_transport("Split changes response: #{result.to_s}")
@config.split_logger.log_if_transport("Feature flag changes response: #{result.to_s}")

bucket = BinarySearchLatencyTracker.get_bucket((Time.now - start) * 1000.0)
@telemetry_runtime_producer.record_sync_latency(Telemetry::Domain::Constants::SPLIT_SYNC, bucket)
Expand All @@ -32,10 +32,10 @@ def since(since, fetch_options = { cache_control_headers: false, till: nil })
else
@telemetry_runtime_producer.record_sync_error(Telemetry::Domain::Constants::SPLIT_SYNC, response.status)

@config.logger.error("Unexpected status code while fetching splits: #{response.status}. " \
@config.logger.error("Unexpected status code while fetching feature flags: #{response.status}. " \
'Check your API key and base URI')

raise 'Split SDK failed to connect to backend to fetch split definitions'
raise 'Split SDK failed to connect to backend to fetch feature flags definitions'
end
end

Expand Down
10 changes: 5 additions & 5 deletions spec/engine/api/splits_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
returned_splits = splits_api.since(-1)
expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))

expect(log.string).to include '2 splits retrieved. since=-1'
expect(log.string).to include '2 feature flags retrieved. since=-1'
expect(log.string).to include returned_splits.to_s
end

Expand All @@ -63,7 +63,7 @@
returned_splits = splits_api.since(-1, fetch_options)
expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))

expect(log.string).to include '2 splits retrieved. since=-1'
expect(log.string).to include '2 feature flags retrieved. since=-1'
expect(log.string).to include returned_splits.to_s
end

Expand All @@ -84,7 +84,7 @@
returned_splits = splits_api.since(-1, fetch_options)
expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))

expect(log.string).to include '2 splits retrieved. since=-1'
expect(log.string).to include '2 feature flags retrieved. since=-1'
expect(log.string).to include returned_splits.to_s
end

Expand All @@ -93,9 +93,9 @@
.to_return(status: 404)

expect { splits_api.since(-1) }.to raise_error(
'Split SDK failed to connect to backend to fetch split definitions'
'Split SDK failed to connect to backend to fetch feature flags definitions'
)
expect(log.string).to include 'Unexpected status code while fetching splits'
expect(log.string).to include 'Unexpected status code while fetching feature flags'
end

it 'throws exception if request to get splits from API fails' do
Expand Down