[FME-12436] Updated commons version#57
Merged
Merged
Conversation
EmilianoSanchez
approved these changes
Jan 19, 2026
EmilianoSanchez
left a comment
EmilianoSanchez
left a comment
There was a problem hiding this comment.
LGTM, but there are a few suggestions to check.
| continue | ||
| } | ||
| if !isValidTreatment(&treatment) { | ||
| logger.Error(fmt.Sprintf("Fallback treatments - Discarded global fallback: Invalid treatment (max %d chars and comply with %s)", MaxTreatmentLength, TreatmentRegexp)) |
There was a problem hiding this comment.
Suggested change
| logger.Error(fmt.Sprintf("Fallback treatments - Discarded global fallback: Invalid treatment (max %d chars and comply with %s)", MaxTreatmentLength, TreatmentRegexp)) | |
| logger.Error(fmt.Sprintf("Fallback treatments - Discarded byFlag fallback: Invalid treatment (max %d chars and comply with %s)", MaxTreatmentLength, TreatmentRegexp)) |
| ErrSplitNotFound = errors.New("split not found") | ||
| ) | ||
|
|
||
| var featureFlagsRules = []string{constants.MatcherTypeAllKeys, constants.MatcherTypeInSegment, constants.MatcherTypeWhitelist, constants.MatcherTypeEqualTo, constants.MatcherTypeGreaterThanOrEqualTo, constants.MatcherTypeLessThanOrEqualTo, constants.MatcherTypeBetween, |
There was a problem hiding this comment.
Could featureFlagsRules and ruleBasedSegmentRules be reused? maybe in a single var called targetingRules?
Contributor
Author
There was a problem hiding this comment.
No, because we have different matchers.
nmayorsplit
added a commit
that referenced
this pull request
Jul 21, 2026
[FME-12436] Updated commons version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPLIT DAEMON
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes