Avoid useless queue ops in ConcurrentLruCache.clear() - #37292
Merged
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
ConcurrentLruCache.clear() previously drained write operations before cleaning up the cache. This could re-enqueue nodes that clear() was about to remove, causing useless evictionQueue operations. Now clear() iterates the cache values directly, removes and marks nodes as removed first, and drains write operations afterward. Since AddTask fails silently after a node is marked removed, this avoids the no-op work and improves performance. See spring-projectsgh-37287 Closes spring-projectsgh-37292 Signed-off-by: Chengang Guan <guanchengang@qq.com>
Contributor
|
Fixed via b49252e |
Member
|
This has been merged into Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConcurrentLruCache.clear()previously drained write operations before cleaning up the cache. This could re-enqueue nodes thatclear()was about to remove, causing useless evictionQueue operations. Nowclear()iterates the cache values directly, removes and marks nodes as removed first, and drains write operations afterward. Since AddTask fails silently after a node is marked removed, this avoids the no-op work and improves performance.See gh-37287