Skip to content

fix: pointers overrides skip imports in generated query files - #2240

Merged
kyleconroy merged 1 commit into
sqlc-dev:mainfrom
ludusrusso:fix-2239
Apr 28, 2023
Merged

fix: pointers overrides skip imports in generated query files#2240
kyleconroy merged 1 commit into
sqlc-dev:mainfrom
ludusrusso:fix-2239

Conversation

@ludusrusso

@ludusrusso ludusrusso commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

fixes #2239

@kyleconroy sorry but it seems that my previous PR was not complete.

@kyleconroy
kyleconroy merged commit d8f1f73 into sqlc-dev:main Apr 28, 2023
@tschaub

tschaub commented Jun 7, 2023

Copy link
Copy Markdown

I think I'm running into the same issue that this fix addresses (see #2304).

@ludusrusso - do you know of the most recent release where imports are included in the generated files (I know things worked at 1.12.0)?

@ludusrusso

Copy link
Copy Markdown
Contributor Author

I think I'm running into the same issue that this fix addresses (see #2304).

@ludusrusso - do you know of the most recent release where imports are included in the generated files (I know things worked at 1.12.0)?

1.16 should work!

@tschaub

tschaub commented Jun 7, 2023

Copy link
Copy Markdown

1.16 should work!

Thanks.

I was hoping to also find a solution to #1956 (which is present in 1.16). Hoping for a patch release that includes your fix at some point.

alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointers overrides arguments still not imported properly in codegen in v1.18

3 participants