feat(template): Check that Helm defined templates carry the chart name - #647
Merged
Conversation
Adds a script called by prek which walks our charts and checks whether all defines/calls use a namespaced name stackabletech/issues#882
lfrancke
force-pushed
the
push-uxpqnklnznyt
branch
from
September 3, 2026 10:05
52ad078 to
c91762d
Compare
lfrancke
marked this pull request as ready for review
September 3, 2026 10:08
Maleware
self-requested a review
September 4, 2026 07:13
Techassi
self-requested a review
September 4, 2026 07:30
Techassi
reviewed
Sep 4, 2026
* Rename vairable * Fix the locale so it doesn't depend on the machine * Switch to a named capture group
The unittest cases in scripts/ had no runner, so they only ran when someone remembered to. The hook also picks up the cases in ensure_one_trailing_newline.py.
Techassi
reviewed
Sep 8, 2026
Techassi
left a comment
Member
There was a problem hiding this comment.
LGTM, just a two more variable rename suggestion.
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
The suggestion that renamed chart to chart_name overlapped this one, so applying them in order kept the old parameter name.
Techassi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script called by prek which walks our charts and checks whether all defines/calls use a namespaced name
I tested it locally:
This was a checkout before the rollout of #645
It succeeds on main now.
stackabletech/issues#882