Skip to content

refactor: Flatten role configs - #945

Merged
adwk67 merged 8 commits into
mainfrom
refactor/flatten-config-maps
Sep 18, 2026
Merged

adwk67 merged 8 commits into
mainfrom
refactor/flatten-config-maps

Conversation

@adwk67

@adwk67 adwk67 commented Sep 14, 2026

Copy link
Copy Markdown
Member

Description

Part of https://github.com/stackabletech/internal-issues/issues/167.

--- PASS: kuttl (1561.19s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/orphaned-resources_trino-latest-481_openshift-false (71.10s)
        --- PASS: kuttl/harness/cluster-operation_trino-latest-481_openshift-false (141.73s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-true_use-tls-true_use-internal-tls-true_openshift-false (72.35s)
        --- PASS: kuttl/harness/logging_trino-481_openshift-false (132.24s)
        --- PASS: kuttl/harness/delta_trino-delta-477_hive-latest-4.2.0_s3-use-tls-true_openshift-false (181.41s)
        --- PASS: kuttl/harness/smoke_trino-481_hive-4.2.0_opa-latest-1.16.2_hdfs-3.5.0_zookeeper-3.9.5_openshift-false (471.09s)
        --- PASS: kuttl/harness/delta_trino-delta-477_hive-latest-4.2.0_s3-use-tls-false_openshift-false (129.07s)
        --- PASS: kuttl/harness/client-spooling_trino-latest-481_openshift-false (143.77s)
        --- PASS: kuttl/harness/listener_trino-481_openshift-false (76.29s)
        --- PASS: kuttl/harness/opa-authorization_trino-481_hive-latest-4.2.0_opa-latest-1.16.2_keycloak-25.0.0_openshift-false (357.59s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-true_use-tls-false_use-internal-tls-false_openshift-false (79.90s)
        --- PASS: kuttl/harness/fault-tolerant-execution_trino-481_openshift-false (161.75s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-true_use-tls-true_use-internal-tls-false_openshift-false (68.82s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-true_use-tls-false_use-internal-tls-true_openshift-false (63.37s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-false_use-tls-true_use-internal-tls-false_openshift-false (64.35s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-false (66.34s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-false_use-tls-false_use-internal-tls-true_openshift-false (68.67s)
        --- PASS: kuttl/harness/authentication_trino-latest-481_ldap-use-tls-false_openshift-false (290.34s)
        --- PASS: kuttl/harness/authentication_trino-latest-481_ldap-use-tls-true_openshift-false (321.81s)
        --- PASS: kuttl/harness/resources_trino-latest-481_openshift-false (56.66s)
        --- PASS: kuttl/harness/tls_trino-latest-481_use-authentication-false_use-tls-false_use-internal-tls-false_openshift-false (57.86s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber
siegfriedweber self-requested a review September 16, 2026 07:03
@adwk67
adwk67 marked this pull request as ready for review September 16, 2026 10:17
@adwk67 adwk67 self-assigned this Sep 16, 2026
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
Comment thread rust/operator-binary/src/controller/build/properties/config_properties.rs Outdated
Comment thread rust/operator-binary/src/crd/mod.rs Outdated
Comment thread rust/operator-binary/src/crd/mod.rs Outdated

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67
adwk67 added this pull request to the merge queue Sep 18, 2026
Merged via the queue into main with commit 32262ff Sep 18, 2026
13 checks passed
@adwk67
adwk67 deleted the refactor/flatten-config-maps branch September 18, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants