chore(release): publish versioned c7n docs tarball to S3#7
Open
jtroup wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-7788
what
Two additions to the
Publishjob instacklet-release.yml:Assert prerelease versionstep, first after checkout:it reads the version from
pyproject.tomland fails the releasebefore anything is built or published if the version isn't a
prerelease (
…aN).(
make sphinx) and upload the HTML tree as a version-keyedtarball (
<version>.tar.gz) to thestacklet-c7n-prerelease-docsS3 bucket.
Separately, in
tools/c7n_awscc/c7n_awscc/manager.py,initialize_resourcenow only registers thedeleteaction when theresource's CloudFormation schema actually declares a
deletehandler,mirroring the existing guard on the
updateaction.why
The Stacklet platform docs site surfaces the Cloud Custodian reference
docs by fetching a prebuilt tarball keyed on the c7n version it
pins. Publishing that tarball from the same release that ships the
wheels keeps the docs locked to the released version, with no separate
pipeline to drift out of step. This repo should only ever ship
prereleases, so asserting that once, up front, guards the whole release
— wheels and docs — against a misconfigured version.
The AWSCC
data/*.jsonschema files are gitignored and fetched freshat build time, and the current schemas include resources with no
deletehandler. The code unconditionally readrinfo["handlers"]["delete"]["permissions"], raisingKeyError: 'delete'duringload_resources(), which broke import — and thereforetest collection — for every suite that loads resources; in CI it
surfaced as ~24 collection errors across the
c7n_kubetests.testing
Relying on CI.
docs
N/A
🤖 Generated with Claude Code