Skip to content

feat: also request "stacklet/platform" scope [ENG-6478]#94

Merged
albertodonato merged 2 commits into
mainfrom
ack/add-platform-scope
Jan 23, 2026
Merged

feat: also request "stacklet/platform" scope [ENG-6478]#94
albertodonato merged 2 commits into
mainfrom
ack/add-platform-scope

Conversation

@albertodonato

@albertodonato albertodonato commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

ENG-6478

what

add the stacklet/platform scope to the ones requested at login

why

given the client accesses the platform API, it should request the scope

testing

tested locally and verified the resulting access token has the additional scope

docs

n/a

@albertodonato albertodonato requested a review from a team as a code owner January 22, 2026 17:25

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread stacklet/client/platform/vendored/auth.py Outdated

@fwereade fwereade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, I don't really think scope ordering matters but I wouldn't object to consistency either.

Comment thread stacklet/client/platform/vendored/auth.py Outdated
[ENG-6478](https://stacklet.atlassian.net/browse/ENG-6478)

### what

add the `stacklet/platform` scope to the ones requested at login

### why

given the client accesses the platform API, it should request the scope

### testing

tested locally and verified the resulting access token has the additional scope

### docs

n/a
@albertodonato albertodonato force-pushed the ack/add-platform-scope branch from 9f22c57 to 73fab7b Compare January 23, 2026 10:17
@albertodonato albertodonato merged commit b14d809 into main Jan 23, 2026
12 checks passed
@albertodonato albertodonato deleted the ack/add-platform-scope branch January 23, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants