Skip to content

fix(tests): use regexes for better exclusions#925

Draft
Molter73 wants to merge 3 commits into
mainfrom
mauro/fix/exclude-broken-vms
Draft

fix(tests): use regexes for better exclusions#925
Molter73 wants to merge 3 commits into
mainfrom
mauro/fix/exclude-broken-vms

Conversation

@Molter73

Copy link
Copy Markdown
Collaborator

Description

The images we use from RHCOS may change from underneatch our feet, so we use regexes to exclude broader patterns that we know won't work with fact.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

  • Verify all expected RHCOS VMs run the tests
  • Update collector ref to master before merging.

The images we use from RHCOS may change from underneatch our feet, so we
use regexes to exclude broader patterns that we know won't work with fact.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: bacd8fc7-2c3b-4591-a8ee-a0e0458b7dea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mauro/fix/exclude-broken-vms

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.72%. Comparing base (0480c62) to head (781c781).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   32.72%   32.72%           
=======================================
  Files          21       21           
  Lines        2695     2695           
  Branches     2695     2695           
=======================================
  Hits          882      882           
  Misses       1810     1810           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants